Skip to content

Missing feature checks and tests #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2020
Merged

Missing feature checks and tests #589

merged 2 commits into from
Apr 17, 2020

Conversation

@jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Apr 16, 2020

Update the features module for code missed in #441 when adding support for payment_secret and basic_mpp features.

jkczyz added 2 commits April 15, 2020 18:21
@jkczyz
Add missing feature sanity checks
fe73761 
PaymentSecret and BasicMPP were added in d39f258
but the sanity test for supported features was missed.
@jkczyz
Add missing known features in constructor
8ca6cb7 
PaymentSecret and BasicMPP were added in d39f258
but were not accounted for in with_known_relevant_init_flags.
@jkczyz jkczyz mentioned this pull request Apr 16, 2020
Merged
TheBlueMatt
TheBlueMatt approved these changes Apr 17, 2020
View reviewed changes
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheBlueMatt TheBlueMatt merged commit a44454e into lightningdevkit:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz @TheBlueMatt